slightly clarify todos

pull/35/head
Miepee 4 years ago
parent 4f7032a93e
commit e4029efae7

@ -154,10 +154,6 @@ public static class HelperMethods
/// <returns><see langword="true"/> if we have internet, <see langword="false"/> if not.</returns>
public static bool IsConnectedToInternet()
{
// TODO: For some reason, using the below approach creates zombie process when checking for Xdelta
// I have no idea why, but I also can't be bothered to troubleshoot why that is the case right now.
// Until someone figures out why that is the case, and makes the below approach not create zombie processes
// it will stay commented out.
log.Info("Checking internet connection...");
HttpWebRequest request = (HttpWebRequest)WebRequest.Create("https://github.com");
try
@ -172,6 +168,10 @@ public static class HelperMethods
log.Info("Internet connection established!");
return true;
// TODO: For some reason, using the below approach creates zombie process when checking for Xdelta
// I have no idea why, but I also can't be bothered to troubleshoot why that is the case right now.
// Until someone figures out why that is the case, and makes the below approach not create zombie processes
// it will stay commented out and the slower above approach will be used instead.
/*log.Info("Checking internet connection...");
try
{

@ -473,7 +473,7 @@ public static class Profile
log.Info("Linux specific formatting finished.");
#if NOAPPIMAGE
// TODO: figure out a way to use patchelf to get rid of deprecated ssl stuff
// TODO: figure out a way to use patchelf to have users not rely on deprecated insecure ssl deps.
#else
// Copy AppImage template to here
HelperMethods.DirectoryCopy($"{Core.PatchDataPath}/data/AM2R.AppDir", $"{profilePath}/AM2R.AppDir/");

Loading…
Cancel
Save