From e4029efae7ce0d112245e86e8516af871c675a22 Mon Sep 17 00:00:00 2001 From: Miepee Date: Tue, 27 Sep 2022 14:30:19 +0200 Subject: [PATCH] slightly clarify todos --- AM2RLauncher/AM2RLauncherLib/HelperMethods.cs | 8 ++++---- AM2RLauncher/AM2RLauncherLib/Profile.cs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/AM2RLauncher/AM2RLauncherLib/HelperMethods.cs b/AM2RLauncher/AM2RLauncherLib/HelperMethods.cs index f80120e..8022e04 100644 --- a/AM2RLauncher/AM2RLauncherLib/HelperMethods.cs +++ b/AM2RLauncher/AM2RLauncherLib/HelperMethods.cs @@ -154,10 +154,6 @@ public static class HelperMethods /// if we have internet, if not. public static bool IsConnectedToInternet() { - // TODO: For some reason, using the below approach creates zombie process when checking for Xdelta - // I have no idea why, but I also can't be bothered to troubleshoot why that is the case right now. - // Until someone figures out why that is the case, and makes the below approach not create zombie processes - // it will stay commented out. log.Info("Checking internet connection..."); HttpWebRequest request = (HttpWebRequest)WebRequest.Create("https://github.com"); try @@ -172,6 +168,10 @@ public static class HelperMethods log.Info("Internet connection established!"); return true; + // TODO: For some reason, using the below approach creates zombie process when checking for Xdelta + // I have no idea why, but I also can't be bothered to troubleshoot why that is the case right now. + // Until someone figures out why that is the case, and makes the below approach not create zombie processes + // it will stay commented out and the slower above approach will be used instead. /*log.Info("Checking internet connection..."); try { diff --git a/AM2RLauncher/AM2RLauncherLib/Profile.cs b/AM2RLauncher/AM2RLauncherLib/Profile.cs index 6b9f0d2..7e2d750 100644 --- a/AM2RLauncher/AM2RLauncherLib/Profile.cs +++ b/AM2RLauncher/AM2RLauncherLib/Profile.cs @@ -473,7 +473,7 @@ public static class Profile log.Info("Linux specific formatting finished."); #if NOAPPIMAGE - // TODO: figure out a way to use patchelf to get rid of deprecated ssl stuff + // TODO: figure out a way to use patchelf to have users not rely on deprecated insecure ssl deps. #else // Copy AppImage template to here HelperMethods.DirectoryCopy($"{Core.PatchDataPath}/data/AM2R.AppDir", $"{profilePath}/AM2R.AppDir/");